Professional Joomla templates and extensions club

ketkoota

I love the Simple contact module but wanted to propose a revision. I had a contractor modify the module to add two features:

1. The ability to narrow the contact list by Contact Group ID
2. The ability to display the contacts in a grid format instead of a list

I humbly submit the file to Joomla!Junkie for possible inclusion in a future release.

Details below, as included in the readme.txt file:
- Every modification are marked with token:
//dauthanhhai@gmail.com - start

//dathanhhai@gmail.com -end

I tried to make modifying code grouped. If you want to upgrade in future. Just copy those area to new files.

File modified:
- mod_simplecontact.xml: add more option area
- mod_simplecontact.php: add statement to choose layout file
- help.php : add more query based on options
- tmpl/grid.php: new file to switch layout; just copy this to new version.

Attached Files

mod_simplecontact-revised.zip (30.5 KB, 3 views)

Andy

Hi There,

Thanks for submitting these updates :) its great when members give back!

I have gone through the changes and they are very sensible and having the ability to choose a tmpl file is a nice addition. The only thing that needs a rethink is the inline css being added to the page using the css variables.

Currently they are being added to the <dl> using the inline "style" attribute like so

Its good practice to keep all styling separate from the html for a number of important reasons, most of which is maintenance, they are less accessible and to keep the html clean and code count as low as possible.

See a good basic article about this here:

Best Practices: Avoid CSS Inline Styles

This is why using a class with php generated CSS is better, so...

The cleaner approach is to add a class to the div and then output the css to the selector using "addStyleDeclaration"

.someClass {
width: $contact_width;
height:$contact_height;
margin: $contact_margin;
padding:$contact_padding;
}

I will play with this a little when I get some time and try implement this change.

Thanks again for sending the updates back to us :)

Cheers,

Andy